Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZDF add episode to title #976

Merged
merged 7 commits into from
May 11, 2024
Merged

ZDF add episode to title #976

merged 7 commits into from
May 11, 2024

Conversation

codingPF
Copy link
Member

Add season and episode to title of ZDF films.
It will be added as " (S<>E<>)" at the end of the title

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@pidoubleyou
Copy link
Contributor

programs like 'heute journal' or 'hallo deutschland' are also labeled with season and episodes, e.g. 'hallo deutschland vom 29. April 2024 (S2024E79). is this ok?

@codingPF
Copy link
Member Author

I like the S notation - did not check if it is consistently incrementing each year but that’s what they provide / use - fine for me.

Can you reconsider you two digit reformatting commit? IMHO it only makes sense if you can sort by episode but since episode is at the end of the title - it is not sorting any way. I would prefer to keep it simple (in==out). But up to you…

@codingPF codingPF changed the title add episode to title ZDF add episode to title May 8, 2024
@codingPF codingPF merged commit 41af0de into develop May 11, 2024
2 of 3 checks passed
@codingPF codingPF deleted the feature/942 branch May 11, 2024 21:01
@dadidadit dadidadit mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants